Исправление Vsevolod-linuxoid, (текущая версия) :
In comparison, here's his post from last November over a similar issue:
You add new drivers and then default them to «on».
THAT IS COMPLETELY UNACCEPTABLE.
I don't know why I have to say this every single merge window, but let's do it one more time:
As a developer, you think _your_ driver or feature is the most important thing ever, and you have the hardware.
AND ALMOST NOBODY ELSE CARES.
Read it and weep. Unless your hardware is completely ubiquitous, it damn well should not default to being defaulted everybody elses config. ... But something like CONFIG_DELL_SMBIOS sure as hell does not merit being default on. Not even if you have enabled WMI.
EVERY SINGLE «default» line that got added by this branch was wrong.
Stop doing this. It's a serious violation of peoples expectations. When I do «make oldconfig», I don't want some new random hardware support.
There was also another situation today testing Torvalds' patience when it came to a kernel oops, with the reformed Torvalds writing:
On my laptop I'm getting a kernel page fault with the current git tree, and I'm tentatively blaming commit
9ee3e06610fd («HID: i2c-hid: override HID descriptors for certain devices»)
but that's simply because it's the only thing that seems to touch this particular area in this merge window.
The oops looks like this: ... which is why I suspect that new i2c_hid_get_dmi_hid_report_desc_override() code.
I *think* the problem is that the i2c_hid_dmi_desc_override_table[] isn't terminated by a NULL entry, and I will test that next.
What makes me *very* unhappy about this is that if I'm right, I think it means that code was literally not tested at all by anybody who didn't have one of the entries in that list.
Исходная версия Vsevolod-linuxoid, :
In comparison, here's his post from last November over a similar issue: You add new drivers and then default them to «on».
THAT IS COMPLETELY UNACCEPTABLE.
I don't know why I have to say this every single merge window, but let's do it one more time:
As a developer, you think _your_ driver or feature is the most important thing ever, and you have the hardware.
AND ALMOST NOBODY ELSE CARES.
Read it and weep. Unless your hardware is completely ubiquitous, it damn well should not default to being defaulted everybody elses config. ... But something like CONFIG_DELL_SMBIOS sure as hell does not merit being default on. Not even if you have enabled WMI.
EVERY SINGLE «default» line that got added by this branch was wrong.
Stop doing this. It's a serious violation of peoples expectations. When I do «make oldconfig», I don't want some new random hardware support.
There was also another situation today testing Torvalds' patience when it came to a kernel oops, with the reformed Torvalds writing:
On my laptop I'm getting a kernel page fault with the current git tree, and I'm tentatively blaming commit
9ee3e06610fd («HID: i2c-hid: override HID descriptors for certain devices»)
but that's simply because it's the only thing that seems to touch this particular area in this merge window.
The oops looks like this: ... which is why I suspect that new i2c_hid_get_dmi_hid_report_desc_override() code.
I *think* the problem is that the i2c_hid_dmi_desc_override_table[] isn't terminated by a NULL entry, and I will test that next.
What makes me *very* unhappy about this is that if I'm right, I think it means that code was literally not tested at all by anybody who didn't have one of the entries in that list.